[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <86cz9doctj.wl-maz@kernel.org>
Date: Wed, 23 Nov 2022 16:28:08 +0000
From: Marc Zyngier <maz@...nel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: tglx@...utronix.de, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
youlin.pei@...iatek.com, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array
On Wed, 23 Nov 2022 14:57:02 +0000,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> wrote:
>
> >> + enum mtk_cirq_reg_index idx,
> >> + unsigned int cirq_num)
> >
> > What does cirq_num mean for registers that are not relative to an
> > interrupt? Create a separate helper for those.
> >
> Means literally nothing, so yes I agree, but...
>
> ... mtk_cirq_irq_reg(), mtk_cirq_reg() feels too similar and may lead to
> confusion while reading the code.
>
> Any advice about a possibly clear-er name?
I think the names are OK. Passing an interrupt number as a parameter
is a good discriminant anyway.
Please wait for a few days before posting the next version though.
M.
--
Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists