linux-kernel - Re: [PATCH v3 2/4] ufs: core: Remove redundant desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b83887215e8f80626b9424c50d60306a1cc24aa.camel@iokpp.de>
Date:   Wed, 23 Nov 2022 18:10:42 +0100
From:   Bean Huo <beanhuo@...pp.de>
To:     Arthur Simchaev <Arthur.Simchaev@....com>,
        martin.petersen@...cle.com
Cc:     beanhuo@...ron.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] ufs: core: Remove redundant desc_size variable
 from hba

On Mon, 2022-11-21 at 17:46 +0200, Arthur Simchaev wrote:
> @ -7945,18 +7926,16 @@ static void ufshcd_clear_dbg_ufs_stats(struct
> ufs_hba *hba)
> 
>  static int ufshcd_device_geo_params_init(struct ufs_hba *hba)
> 
>  {
> 
>         int err;
> 
> -       size_t buff_len;
> 
>         u8 *desc_buf;
> 
>  
> 
> -       buff_len = hba->desc_size[QUERY_DESC_IDN_GEOMETRY];
> 
> -       desc_buf = kmalloc(buff_len, GFP_KERNEL);
> 
> +       desc_buf = kmalloc(QUERY_DESC_MAX_SIZE, GFP_KERNEL);
here also should be kzalloc?

Reviewed-by: Bean Huo <beanhuo@...ron.com>