linux-kernel - Re: [PATCH v3 3/4] ufs: core: Remove len parameter from ufshcd_set_active_icc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 18:18:10 +0100
From:   Bean Huo <beanhuo@...pp.de>
To:     Arthur Simchaev <Arthur.Simchaev@....com>,
        martin.petersen@...cle.com
Cc:     beanhuo@...ron.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] ufs: core: Remove len parameter from
 ufshcd_set_active_icc_lvl

On Mon, 2022-11-21 at 17:46 +0200, Arthur Simchaev wrote:
> len argument is not used anymore in ufshcd_set_active_icc_lvl
> function.
> 
> Signed-off-by: Arthur Simchaev <Arthur.Simchaev@....com>
> ---
>  drivers/ufs/core/ufshcd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 7456aa2..604348f 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -7391,12 +7391,11 @@ static u32 ufshcd_get_max_icc_level(int
> sup_curr_uA, u32 start_scan,
>   * In case regulators are not initialized we'll return 0
>   * @hba: per-adapter instance
>   * @desc_buf: power descriptor buffer to extract ICC levels from.
> - * @len: length of desc_buff
>   *
>   * Returns calculated ICC level
>   */
>  static u32 ufshcd_find_max_sup_active_icc_level(struct ufs_hba *hba,
> -						const u8 *desc_buf, int
> len)
> +						const u8 *desc_buf)


The Linux kernel already deprecates the 80 character per line coding
style, so you could keep one line here after removing len.


Reviewed-by: Bean Huo <beanhuo@...ron.com>