linux-kernel - RE: [PATCH 4/5] driver core: make struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 11:23:36 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>,
        Alison Schofield <alison.schofield@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        "Ben Widawsky" <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Jeremy Kerr <jk@...abs.org>, Joel Stanley <joel@....id.au>,
        Alistar Popple <alistair@...ple.id.au>,
        Eddie James <eajames@...ux.ibm.com>,
        "Alexander Shishkin" <alexander.shishkin@...ux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Jilin Yuan <yuanjilin@...rlc.com>,
        "Heikki Krogerus" <heikki.krogerus@...ux.intel.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Won Chung <wonchung@...gle.com>, <linux-block@...r.kernel.org>,
        <linux-cxl@...r.kernel.org>, <linux-fsi@...ts.ozlabs.org>,
        <linux-usb@...r.kernel.org>
Subject: RE: [PATCH 4/5] driver core: make struct device_type.devnode() take
 a const *

Greg Kroah-Hartman wrote:
> The devnode() callback in struct device_type should not be modifying the
> device that is passed into it, so mark it as a const * and propagate the
> function signature changes out into all relevant subsystems that use
> this callback.
> 
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Alison Schofield <alison.schofield@...el.com>
> Cc: Vishal Verma <vishal.l.verma@...el.com>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: Ben Widawsky <bwidawsk@...nel.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Jeremy Kerr <jk@...abs.org>
> Cc: Joel Stanley <joel@....id.au>
> Cc: Alistar Popple <alistair@...ple.id.au>
> Cc: Eddie James <eajames@...ux.ibm.com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Cc: Jilin Yuan <yuanjilin@...rlc.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Cc: Won Chung <wonchung@...gle.com>
> Cc: linux-block@...r.kernel.org
> Cc: linux-cxl@...r.kernel.org
> Cc: linux-fsi@...ts.ozlabs.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
[..]
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index 20ce488a7754..6ae8d0bdc61b 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -27,7 +27,7 @@ static void cxl_memdev_release(struct device *dev)
>  	kfree(cxlmd);
>  }
>  
> -static char *cxl_memdev_devnode(struct device *dev, umode_t *mode, kuid_t *uid,
> +static char *cxl_memdev_devnode(const struct device *dev, umode_t *mode, kuid_t *uid,
>  				kgid_t *gid)
>  {
>  	return kasprintf(GFP_KERNEL, "cxl/%s", dev_name(dev));

For the CXL bit:

Acked-by: Dan Williams <dan.j.williams@...el.com>