linux-kernel - Re: nbd: please don't spawn 16 threads when nbd is not even in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Nov 2022 23:01:00 +0100
From:   Pavel Machek <pavel@....cz>
To:     Eric Blake <eblake@...hat.com>
Cc:     kernel list <linux-kernel@...r.kernel.org>, josef@...icpanda.com,
        linux-block@...r.kernel.org, nbd@...er.debian.org
Subject: Re: nbd: please don't spawn 16 threads when nbd is not even in use

Hi!

> > I see this... and it looks like there are 16 workqueues before nbd is
> > even used. Surely there are better ways to do that?
> 
> Yes, it would be nice to create a pool of workers that only spawns up
> threads when actual parallel requests are made.  Are you willing to
> help write the patch?

I was thinking more "only spawn a workqueue when nbd is opened" or so.

I have 16 of them, and I'm not using nbd. Workqueue per open device is
okay, current situation... not so much.

      	       	    	  	  	    	     		Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)