linux-kernel - Re: nbd: please don't spawn 16 threads when nbd is not even in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccee0ff5-309c-b430-09c7-8d2081c9981d@huaweicloud.com>
Date:   Thu, 24 Nov 2022 09:17:51 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Pavel Machek <pavel@....cz>, Eric Blake <eblake@...hat.com>
Cc:     kernel list <linux-kernel@...r.kernel.org>, josef@...icpanda.com,
        linux-block@...r.kernel.org, nbd@...er.debian.org,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: nbd: please don't spawn 16 threads when nbd is not even in use

Hi,

在 2022/11/24 6:01, Pavel Machek 写道:
> Hi!
> 
>>> I see this... and it looks like there are 16 workqueues before nbd is
>>> even used. Surely there are better ways to do that?
>>
>> Yes, it would be nice to create a pool of workers that only spawns up
>> threads when actual parallel requests are made.  Are you willing to
>> help write the patch?
> 
> I was thinking more "only spawn a workqueue when nbd is opened" or so.
> 
> I have 16 of them, and I'm not using nbd. Workqueue per open device is
> okay, current situation... not so much.

You can take a look at this commit:

e2daec488c57 ("nbd: Fix hungtask when nbd_config_put")

Allocation of recv_workq is moved from start device to alloc device to
fix hungtask. You might need to be careful if you want to move this.

Thanks,
Kuai
> 
>        	       	    	  	  	    	     		Pavel
>