[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b5888b92-ed6c-98c7-0d38-982a31e10e4f@kernel.org>
Date: Wed, 23 Nov 2022 06:39:39 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: "Gabriel L. Somlo" <gsomlo@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
gregkh@...uxfoundation.org, kgugala@...micro.com,
mholenko@...micro.com, joel@....id.au,
david.abdurachmanov@...il.com, florent@...oy-digital.fr,
geert@...ux-m68k.org, ilpo.jarvinen@...ux.intel.com
Subject: Re: [PATCH v5 09/14] serial: liteuart: fix rx loop variable types
On 22. 11. 22, 22:05, Gabriel L. Somlo wrote:
> So, looking at what uart_insert_char() does, I could simply do this
> instead:
>
> while(!litex_read8(membase + OFF_RXEMPTY) {
> ...
> /* LiteUART does not provide overrun bits */
> if (!(uart_handle_sysrq_char(port, ch) ||
> tty_insert_flip_char(&port->state->port, ch, TTY_NORMAL)))
> ++port->icount.buf_overrun;
>
> That is, `tty_insert_flip_char() is the portion of `uart_insert_char()`
> that actually gets executed if status is 1 and overrun is 0...
>
> I'm not quite confident about whether this is an improvement in legibility
> and/or code quality,
It's not :). Keep the uart_ helper.
--
js
suse labs
Powered by blists - more mailing lists