linux-kernel - Re: [PATCH 08/18] net: enetc: fix mixed module-builtin object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAT4asXORsS8Q-NRfGEYo4fsAnMVhQai3C+EeaDhoXv57Q@mail.gmail.com>
Date:   Wed, 23 Nov 2022 22:03:09 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Alexander Lobakin <alobakin@...me>
Cc:     linux-kbuild@...r.kernel.org, Nicolas Schier <nicolas@...sle.eu>,
        Jens Axboe <axboe@...nel.dk>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Tony Luck <tony.luck@...el.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Derek Chickles <dchickles@...vell.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Salil Mehta <salil.mehta@...wei.com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Daniel Scally <djrscally@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        NXP Linux Team <linux-imx@....com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/18] net: enetc: fix mixed module-builtin object

On Sun, Nov 20, 2022 at 8:07 AM Alexander Lobakin <alobakin@...me> wrote:
>
> From: Masahiro Yamada <masahiroy@...nel.org>
>
> With CONFIG_FSL_ENETC=m and CONFIG_FSL_ENETC_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
>
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>
> Introduce the new module, fsl-enetc-core, to provide the common
> functions to fsl-enetc and fsl-enetc-vf.
>
> [ alobakin: add exports to common functions ]
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Reviewed-by: Alexander Lobakin <alobakin@...me>
> Signed-off-by: Alexander Lobakin <alobakin@...me>
> ---
>  drivers/net/ethernet/freescale/enetc/Kconfig  |  5 +++++
>  drivers/net/ethernet/freescale/enetc/Makefile |  7 ++++---
>  drivers/net/ethernet/freescale/enetc/enetc.c  | 21 +++++++++++++++++++
>  .../net/ethernet/freescale/enetc/enetc_cbdr.c |  7 +++++++
>  .../ethernet/freescale/enetc/enetc_ethtool.c  |  2 ++
>  .../net/ethernet/freescale/enetc/enetc_pf.c   |  2 ++
>  .../net/ethernet/freescale/enetc/enetc_vf.c   |  2 ++
>  7 files changed, 43 insertions(+), 3 deletions(-)



I think you can grab Author since I did not finish this patch.
(and of course, I did not test it at all)

You can remove a blank line after MODULE_IMPORT_NS()

Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>






-- 
Best Regards
Masahiro Yamada