[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4d62d7e9-5454-4d1c-b3bb-4ba1fd7a31d6@linaro.org>
Date: Wed, 23 Nov 2022 14:01:30 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Edmund Berenson <edmund.berenson@...ix.com>
Cc: Lukasz Zemla <Lukasz.Zemla@...dward.com>,
Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] dt-bindings: iio: adc: ad7923: adjust documentation
On 23/11/2022 12:32, Edmund Berenson wrote:
> On Wed, Nov 23, 2022 at 11:42:40AM +0100, Krzysztof Kozlowski wrote:
>> On 22/11/2022 17:14, Edmund Berenson wrote:
>>> - The ad7927 is fully compatible with ad7928 driver, add
>>> documentation for device.
>>> - ad7923 and ad7924 are treated the same in the driver, show
>>> the relationship in the documentation.
>>>
>>> Suggested-by: Lukasz Zemla <Lukasz.Zemla@...dward.com>
>>> Signed-off-by: Edmund Berenson <edmund.berenson@...ix.com>
>>> ---
>>> .../bindings/iio/adc/adi,ad7923.yaml | 26 ++++++++++++-------
>>> 1 file changed, 17 insertions(+), 9 deletions(-)
>>>
>>
>> 1. This is a v5, what are the changes?
>>
> The original idea was adding the compatible string into driver itself,
> then it was suggested that I have a fallback compatible to 7928 as the
> hardware versions are treated the same in the driver. After that it was
> suggested to add deprecated flag to standalone compatibility, but doing
> so I didn't want to add compatibility on driver side just to mark it
> deprecated in the documentation, so I dropped driver side changes.
> Finally I had some issues getting the documentation syntax into an
> acceptable form, mainly const vs enum listing of compatibility stings.
That's a bit too long for a changelog. Keep it short but still
descriptive. Anyway - this must be in the changelog place, so after ---
Best regards,
Krzysztof
Powered by blists - more mailing lists