linux-kernel - Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2022 11:45:36 +0800
From:   Kun-Fa Lin <milkfafa@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        openbmc@...ts.ozlabs.org, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, kwliu@...oton.com,
        kflin@...oton.com
Subject: Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM
 VCD and ECE engine

Hi Rob,

Thanks for the review.

> > +title: Nuvoton NPCM Video Capture/Encode Engine Device Tree Bindings
>
> Drop ' Device Tree Bindings'
>
> > +
> > +maintainers:
> > +  - Joseph Liu <kwliu@...oton.com>
> > +  - Marvin Lin <kflin@...oton.com>
> > +
> > +description: |
> > +  Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine
> > +  (ECE) present on Nuvoton NPCM SoCs.
>
> Sounds like 2 h/w blocks? If so, then it should be 2 separate nodes.
>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nuvoton,npcm750-video
> > +      - nuvoton,npcm845-video
>
> 'video' doesn't sound like the name of the h/w block(s).

VCD and ECE are 2 h/w blocks and our video capture driver needs to
control their registers.
If I separate them and store a phandle (referring to ece node) in vcd
node like this:

vcd: vcd@...10000 {
    compatible = "nuvoton,npcm750-vcd";
    reg = <0xf0810000 0x10000>;
    ...
    nuvoton,enc-engine = <&ece>;
};

ece: ece@...20000 {
    compatible = "nuvoton,npcm750-ece";
    reg = <0xf0820000 0x2000>;
    ...
};

Does it look good to you?

Regards,
Marvin