linux-kernel - Re: [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnNmFqswx3VEFBAxUPbznyct2L880H6i6LghF_tAzZ=wS5T8A@mail.gmail.com>
Date:   Thu, 24 Nov 2022 11:53:44 +0800
From:   Kun-Fa Lin <milkfafa@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        openbmc@...ts.ozlabs.org, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, kwliu@...oton.com,
        kflin@...oton.com
Subject: Re: [PATCH v7 3/7] dt-bindings: arm: nuvoton: Add bindings for NPCM GFXI

Hi Krzysztof,

> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.

Thanks for your kind reminder. I'll check for this again.

> > +description:
> > +  The Graphics Core Information (GFXI) are a block of registers in Nuvoton SoCs
> > +  that analyzes Graphics core behavior and provides inforomation in registers.
>
> typo: information
>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - nuvoton,npcm750-gfxi
> > +          - nuvoton,npcm845-gfxi
> > +      - const: syscon
> > +      - const: simple-mfd
>
> That's not simple-mfd, you do not have any devices.

These problems will be addressed in the next patch, thanks for the review.

Regards,
Marvin