linux-kernel - Re: [PATCH 0/2] These are the required patches I found while adding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d812e89c0c8d00f0043463dda241ece5@walle.cc>
Date:   Thu, 24 Nov 2022 13:42:30 +0100
From:   Michael Walle <michael@...le.cc>
To:     Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Cc:     greg.malysa@...esys.com, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, miquel.raynal@...tlin.com,
        pratyush@...nel.org, richard@....at, tudor.ambarus@...rochip.com,
        vigneshr@...com
Subject: Re: [PATCH 0/2] These are the required patches I found while adding

Hi,

Am 2022-11-24 12:47, schrieb Nathan Barrett-Morrison:
> Ah yes, I just realized we're effectively using the device in 1S-1S-8S
> extended SPI mode, so the 0xC7 setting is probably not required.  We
> were never able to get DTR mode working on the IS25LX256. I can fix
> this patch up so it's more explicit about what's going on here.
> 
> The 8S-8S-8S support in core.c is still going to be used for another
> OSPI device I'm porting over from an older kernel.

Can you link a datasheet? The problem with 8s8s8s is that it needs
mode switching which can be footgun. And IMHO it doesn't provide
significant performance improvements over 1s8s8s.

> Would you like me to separate these patches, fix up the ISSI once, and 
> resubmit?

Yes please. Also, I've seen that you use flags in the flash_info table.
Please have a look if that information can be deduced from the SFDP. 
E.g.
does a flash describe if it supports 1s1s8s.

-michael