linux-kernel - Re: [PATCH 1/2] mtd: spi-nore: core: Add in framework for 8S-8S-8S Octal STR mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 19:12:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        nathan.morrison@...esys.com, greg.malysa@...esys.com,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <pratyush@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mtd: spi-nore: core: Add in framework for 8S-8S-8S
 Octal STR mode

Hi Nathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.1-rc6]
[also build test ERROR on linus/master next-20221125]
[cannot apply to mtd/spi-nor/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Barrett-Morrison/These-are-the-required-patches-I-found-while-adding/20221124-051608
patch link:    https://lore.kernel.org/r/20221123211335.126417-2-nathan.morrison%40timesys.com
patch subject: [PATCH 1/2] mtd: spi-nore: core: Add in framework for 8S-8S-8S Octal STR mode
config: x86_64-randconfig-a001
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/47217ef33736ae6ec01261ed674a9516aa0d6709
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nathan-Barrett-Morrison/These-are-the-required-patches-I-found-while-adding/20221124-051608
        git checkout 47217ef33736ae6ec01261ed674a9516aa0d6709
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/mtd/spi-nor/core.c:2365:30: warning: array index 8192 is past the end of the array (which contains 16 elements) [-Warray-bounds]
                   spi_nor_set_read_settings(&params->reads[SNOR_HWCAPS_READ_8_8_8],
                                              ^             ~~~~~~~~~~~~~~~~~~~~~~
   drivers/mtd/spi-nor/core.h:387:2: note: array 'reads' declared here
           struct spi_nor_read_command     reads[SNOR_CMD_READ_MAX];
           ^
>> drivers/mtd/spi-nor/core.c:2658:20: error: no member named 'octal_str_enable' in 'struct spi_nor_flash_parameter'; did you mean 'octal_dtr_enable'?
           if (!nor->params->octal_str_enable)
                             ^~~~~~~~~~~~~~~~
                             octal_dtr_enable
   drivers/mtd/spi-nor/core.h:393:8: note: 'octal_dtr_enable' declared here
           int (*octal_dtr_enable)(struct spi_nor *nor, bool enable);
                 ^
   drivers/mtd/spi-nor/core.c:2668:21: error: no member named 'octal_str_enable' in 'struct spi_nor_flash_parameter'; did you mean 'octal_dtr_enable'?
           ret = nor->params->octal_str_enable(nor, enable);
                              ^~~~~~~~~~~~~~~~
                              octal_dtr_enable
   drivers/mtd/spi-nor/core.h:393:8: note: 'octal_dtr_enable' declared here
           int (*octal_dtr_enable)(struct spi_nor *nor, bool enable);
                 ^
   1 warning and 2 errors generated.


vim +2658 drivers/mtd/spi-nor/core.c

  2647	
  2648	/** spi_nor_octal_str_enable() - enable Octal STR I/O if needed
  2649	 * @nor:                 pointer to a 'struct spi_nor'
  2650	 * @enable:              whether to enable or disable Octal STR
  2651	 *
  2652	 * Return: 0 on success, -errno otherwise.
  2653	 */
  2654	static int spi_nor_octal_str_enable(struct spi_nor *nor, bool enable)
  2655	{
  2656		int ret;
  2657	
> 2658		if (!nor->params->octal_str_enable)
  2659			return 0;
  2660	
  2661		if (!(nor->read_proto == SNOR_PROTO_8_8_8 &&
  2662		      nor->write_proto == SNOR_PROTO_8_8_8))
  2663			return 0;
  2664	
  2665		if (!(nor->flags & SNOR_F_IO_MODE_EN_VOLATILE))
  2666			return 0;
  2667	
  2668		ret = nor->params->octal_str_enable(nor, enable);
  2669		if (ret)
  2670			return ret;
  2671	
  2672		if (enable)
  2673			nor->reg_proto = SNOR_PROTO_8_8_8;
  2674		else
  2675			nor->reg_proto = SNOR_PROTO_1_1_1;
  2676	
  2677		return 0;
  2678	}
  2679	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (151550 bytes)