linux-kernel - Re: [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in Octal STR mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 23:55:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Cc:     oe-kbuild-all@...ts.linux.dev, nathan.morrison@...esys.com,
        greg.malysa@...esys.com,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <pratyush@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256
 chip, operating in Octal STR mode

Hi Nathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.1-rc6]
[also build test ERROR on linus/master next-20221125]
[cannot apply to mtd/spi-nor/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Barrett-Morrison/These-are-the-required-patches-I-found-while-adding/20221124-051608
patch link:    https://lore.kernel.org/r/20221123211335.126417-3-nathan.morrison%40timesys.com
patch subject: [PATCH 2/2] mtd: spi-nor: issi: Add in support for IS25LX256 chip, operating in Octal STR mode
config: i386-randconfig-a001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7b08e6f926d618b3636ad946fe14a1c43d6aed31
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nathan-Barrett-Morrison/These-are-the-required-patches-I-found-while-adding/20221124-051608
        git checkout 7b08e6f926d618b3636ad946fe14a1c43d6aed31
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/mtd/spi-nor/issi.c: In function 'is25lx256_default_init':
>> drivers/mtd/spi-nor/issi.c:100:22: error: 'struct spi_nor_flash_parameter' has no member named 'octal_str_enable'; did you mean 'octal_dtr_enable'?
     100 |         nor->params->octal_str_enable = spi_nor_issi_octal_str_enable;
         |                      ^~~~~~~~~~~~~~~~
         |                      octal_dtr_enable


vim +100 drivers/mtd/spi-nor/issi.c

    97	
    98	static void is25lx256_default_init(struct spi_nor *nor)
    99	{
 > 100		nor->params->octal_str_enable = spi_nor_issi_octal_str_enable;
   101	}
   102	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (153027 bytes)