linux-kernel - Re: [PATCH V2 1/3] Modify to support Phytium FT2000/4 CPU for acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5fbff9f-6fad-fb1d-17a1-9d7da7761c4f@roeck-us.net>
Date:   Thu, 24 Nov 2022 06:25:46 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wang Honghui <honghui.wang@...s.com.cn>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 1/3] Modify to support Phytium FT2000/4 CPU for acpi

On 11/23/22 19:26, Wang Honghui wrote:
> Modify to support Phytium FT2000/4 CPU for acpi
> 
> Signed-off-by: Wang Honghui <honghui.wang@...s.com.cn>
> ---
>   drivers/hwmon/scpi-hwmon.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
> index 6021ae00b334..a6ee9806e47e 100644
> --- a/drivers/hwmon/scpi-hwmon.c
> +++ b/drivers/hwmon/scpi-hwmon.c
> @@ -316,6 +316,7 @@ static struct platform_driver scpi_hwmon_platdrv = {
>   	.driver = {
>   		.name	= "scpi-hwmon",
>   		.of_match_table = scpi_of_match,
> +		.acpi_match_table = scpi_sensors_acpi_match,
>   	},
>   	.probe		= scpi_hwmon_probe,
>   };


This patch on its own doesn't make sense. It seems to be a fix of v1, not
a new version of v1. Your subject lines are off. Modify what ?
The subject should be something like "hwmon: (scpi) Add ACPI support for...".

Guenter