[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4BkJd3Jy6MY3cdu@ZenIV>
Date: Fri, 25 Nov 2022 06:43:49 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Zhen Lei <thunder.leizhen@...wei.com>
Cc: Eric Biggers <ebiggers@...nel.org>, linux-fsdevel@...r.kernel.org,
Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] fs: clear a UBSAN shift-out-of-bounds warning
On Mon, Nov 21, 2022 at 10:44:16AM +0800, Zhen Lei wrote:
> v1 -- > v2:
> 1. Replace INT_LIMIT(loff_t) with OFFSET_MAX in btrfs.
> 2. Replace INT_LIMIT() with type_max().
Looks fine, except that I'd rather go for commit message
along the lines of "INT_LIMIT tries to do what type_max does,
except that type_max doesn't rely upon undefined behaviour;
might as well use type_max() instead"
If you want to credit UBSAN - sure, no problem, just don't
clutter the commit message with that. As it is, it reads
as "make $TOOL STFU"...
Powered by blists - more mailing lists