lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VI1P190MB03173DB0A16402C8AB670D91950E9@VI1P190MB0317.EURP190.PROD.OUTLOOK.COM>
Date:   Fri, 25 Nov 2022 08:43:06 +0000
From:   Vadym Kochan <vadym.kochan@...ision.eu>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof WilczyƄski <kw@...ux.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Elad Nachman <enachman@...vell.com>,
        Raz Adashi <raza@...vell.com>, Yuval Shaia <yshaia@...vell.com>
Subject: Re: [PATCH v2 2/3] PCI: armada8k: Add AC5 SoC support

Hi Thomas,

> On Thu, 24 Nov 2022 15:58:27 +0200
> Vadym Kochan <vadym.kochan@...ision.eu> wrote:
>
>> -static int armada8k_pcie_start_link(struct dw_pcie *pci)
>> -{
>> -     u32 reg;
>> -
>> -     /* Start LTSSM */
>> -     reg = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_CONTROL_REG);
>> -     reg |= PCIE_APP_LTSSM_EN;
>> -     dw_pcie_writel_dbi(pci, PCIE_GLOBAL_CONTROL_REG, reg);
>> -
>> -     return 0;
>> -}
>
>So this code is going away, but I don't see it being re-added anywhere.
>I don't think anything in the code you are adding that sets the
>LTSSM_EN bit in PCIE_GLOBAL_CONTROL_REG. Am I missing something?
>
>Thomas
>--
>Thomas Petazzoni, co-owner and CEO, Bootlin
>Embedded Linux and Kernel engineering and training
>https://bootlin.com

There is a reply from the Marvell:

[quote]
this is not needed, as by the time Linux is loaded, link has already been established (by boot loaders)

So this code is not needed.
[/quote]

Thanks,

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ