[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221125092601.3703-1-abelova@astralinux.ru>
Date: Fri, 25 Nov 2022 12:26:01 +0300
From: Anastasia Belova <abelova@...ralinux.ru>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Anastasia Belova <abelova@...ralinux.ru>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Randy Dunlap <rdunlap@...radead.org>,
Florian Fainelli <f.fainelli@...il.com>,
Maxime Bizon <mbizon@...ebox.fr>,
Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
Check clk for NULL before calling clk_enable_unlocked where clk
is dereferenced. There is such check in other implementations
of clk_enable.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
---
arch/mips/bcm63xx/clk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index 6e6756e8fa0a..401140cf36d9 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -361,6 +361,9 @@ static struct clk clk_periph = {
*/
int clk_enable(struct clk *clk)
{
+ if (!clk)
+ return;
+
mutex_lock(&clocks_mutex);
clk_enable_unlocked(clk);
mutex_unlock(&clocks_mutex);
--
2.30.2
Powered by blists - more mailing lists