[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOiHx=nc46Hj4wDGC0ci8+SrAkJZ9i_7-yZU1D8cWkpS6prGoQ@mail.gmail.com>
Date: Fri, 25 Nov 2022 15:14:50 +0100
From: Jonas Gorski <jonas.gorski@...il.com>
To: Anastasia Belova <abelova@...ralinux.ru>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Randy Dunlap <rdunlap@...radead.org>,
Florian Fainelli <f.fainelli@...il.com>,
Maxime Bizon <mbizon@...ebox.fr>,
Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
On Fri, 25 Nov 2022 at 10:28, Anastasia Belova <abelova@...ralinux.ru> wrote:
>
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@...ralinux.ru>
> ---
> arch/mips/bcm63xx/clk.c | 3 +++
> 1 file changed, 3 insertions(+)
Makes sense, especially since clk_disable() already has a NULL check
(in case anybody else wonders).
Reviewed-by: Jonas Gorski <jonas.gorski@...il.com>
Powered by blists - more mailing lists