linux-kernel - Re: [PATCH] crypto: hisilicon/qm - add device status check when start fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 17:46:40 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Weili Qian <qianweili@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        wangzhou1@...ilicon.com, liulongfang@...wei.com
Subject: Re: [PATCH] crypto: hisilicon/qm - add device status check when
 start fails

On Sat, Nov 19, 2022 at 05:50:03PM +0800, Weili Qian wrote:
> In function 'hisi_qm_resume', if the device fails to be started,
> directly returning error code will cause the device to be unavailable.
> However, the failure may be caused by device error, which will be
> reported to the driver, and driver can reset and restart device.
> Therefore, check device status instead of returning error code
> directly. Returns 0 if device error has occurred, otherwise returns
> error code.
> 
> Signed-off-by: Weili Qian <qianweili@...wei.com>
> ---
>  drivers/crypto/hisilicon/qm.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt