lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Nov 2022 12:42:29 +0100 From: Konrad Dybcio <konrad.dybcio@...aro.org> To: Linus Walleij <linus.walleij@...aro.org> Cc: Kalle Valo <kvalo@...nel.org>, Alvin Šipraga <ALSI@...g-olufsen.dk>, Hector Martin <marcan@...can.st>, "~postmarketos/upstreaming@...ts.sr.ht" <~postmarketos/upstreaming@...ts.sr.ht>, "martin.botka@...ainline.org" <martin.botka@...ainline.org>, "angelogioacchino.delregno@...ainline.org" <angelogioacchino.delregno@...ainline.org>, "marijn.suijten@...ainline.org" <marijn.suijten@...ainline.org>, "jamipkettunen@...ainline.org" <jamipkettunen@...ainline.org>, Arend van Spriel <aspriel@...il.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Marek Vasut <marex@...x.de>, "Zhao, Jiaqing" <jiaqing.zhao@...el.com>, "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Soon Tak Lee <soontak.lee@...ress.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "brcm80211-dev-list.pdl@...adcom.com" <brcm80211-dev-list.pdl@...adcom.com>, "SHA-cyfmac-dev-list@...ineon.com" <SHA-cyfmac-dev-list@...ineon.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi On 21.11.2022 14:56, Linus Walleij wrote: > On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio <konrad.dybcio@...aro.org> wrote: > >> I can think of a couple of hacky ways to force use of 43596 fw, but I >> don't think any would be really upstreamable.. > > If it is only known to affect the Sony Xperias mentioned then > a thing such as: > > if (of_machine_is_compatible("sony,xyz") || > of_machine_is_compatible("sony,zzz")... ) { > // Enforce FW version > } > > would be completely acceptable in my book. It hammers the > problem from the top instead of trying to figure out itsy witsy > details about firmware revisions. > > Yours, > Linus Walleij Actually, I think I came up with a better approach by pulling a page out of Asahi folks' book - please take a look and tell me what you think about this: [1] https://github.com/SoMainline/linux/commit/4b6fccc995cd79109b0dae4e4ab2e48db97695e7 [2] https://github.com/SoMainline/linux/commit/e3ea1dc739634f734104f37fdbed046873921af7 Konrad
Powered by blists - more mailing lists