[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdax-3VVDd29iH51mfumakqM7jyEc8Pbb=AQwAgp2WsqFQ@mail.gmail.com>
Date: Mon, 21 Nov 2022 14:56:31 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Kalle Valo <kvalo@...nel.org>,
Alvin Šipraga <ALSI@...g-olufsen.dk>,
Hector Martin <marcan@...can.st>,
"~postmarketos/upstreaming@...ts.sr.ht"
<~postmarketos/upstreaming@...ts.sr.ht>,
"martin.botka@...ainline.org" <martin.botka@...ainline.org>,
"angelogioacchino.delregno@...ainline.org"
<angelogioacchino.delregno@...ainline.org>,
"marijn.suijten@...ainline.org" <marijn.suijten@...ainline.org>,
"jamipkettunen@...ainline.org" <jamipkettunen@...ainline.org>,
Arend van Spriel <aspriel@...il.com>,
Franky Lin <franky.lin@...adcom.com>,
Hante Meuleman <hante.meuleman@...adcom.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Marek Vasut <marex@...x.de>,
"Zhao, Jiaqing" <jiaqing.zhao@...el.com>,
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
Soon Tak Lee <soontak.lee@...ress.com>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"brcm80211-dev-list.pdl@...adcom.com"
<brcm80211-dev-list.pdl@...adcom.com>,
"SHA-cyfmac-dev-list@...ineon.com" <SHA-cyfmac-dev-list@...ineon.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi
On Fri, Nov 18, 2022 at 5:47 PM Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
> I can think of a couple of hacky ways to force use of 43596 fw, but I
> don't think any would be really upstreamable..
If it is only known to affect the Sony Xperias mentioned then
a thing such as:
if (of_machine_is_compatible("sony,xyz") ||
of_machine_is_compatible("sony,zzz")... ) {
// Enforce FW version
}
would be completely acceptable in my book. It hammers the
problem from the top instead of trying to figure out itsy witsy
details about firmware revisions.
Yours,
Linus Walleij
Powered by blists - more mailing lists