linux-kernel - Re: [PATCH v3 13/13] tty: serial: qcom-geni-serial: add support for serial engine DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211260123.qP5jvhot-lkp@intel.com>
Date:   Sat, 26 Nov 2022 01:36:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, Alex Elder <elder@...nel.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-serial@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 13/13] tty: serial: qcom-geni-serial: add support for
 serial engine DMA

Hi Bartosz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tty/tty-linus]
[also build test WARNING on linus/master v6.1-rc6]
[cannot apply to tty/tty-testing tty/tty-next next-20221125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/serial-qcom-geni-serial-implement-support-for-SE-DMA/20221123-191249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-linus
patch link:    https://lore.kernel.org/r/20221123110759.1836666-14-brgl%40bgdev.pl
patch subject: [PATCH v3 13/13] tty: serial: qcom-geni-serial: add support for serial engine DMA
config: arc-allyesconfig
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5f94e67883d6c82dfe857dcac6dbde75773b8942
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Bartosz-Golaszewski/serial-qcom-geni-serial-implement-support-for-SE-DMA/20221123-191249
        git checkout 5f94e67883d6c82dfe857dcac6dbde75773b8942
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/tty/serial/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_stop_tx_dma':
>> drivers/tty/serial/qcom_geni_serial.c:594:37: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     594 |                 port->tx_dma_addr = (dma_addr_t)NULL;
         |                                     ^
   drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_stop_rx_dma':
   drivers/tty/serial/qcom_geni_serial.c:791:37: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     791 |                 port->rx_dma_addr = (dma_addr_t)NULL;
         |                                     ^
   drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_handle_rx_dma':
   drivers/tty/serial/qcom_geni_serial.c:831:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     831 |         port->rx_dma_addr = (dma_addr_t)NULL;
         |                             ^
   drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_handle_tx_dma':
   drivers/tty/serial/qcom_geni_serial.c:963:29: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     963 |         port->tx_dma_addr = (dma_addr_t)NULL;
         |                             ^


vim +594 drivers/tty/serial/qcom_geni_serial.c

   579	
   580	static void qcom_geni_serial_stop_tx_dma(struct uart_port *uport)
   581	{
   582		struct qcom_geni_serial_port *port = to_dev_port(uport);
   583		bool done;
   584		u32 status;
   585		u32 m_irq_en;
   586	
   587		status = readl(uport->membase + SE_GENI_STATUS);
   588		if (!(status & M_GENI_CMD_ACTIVE))
   589			return;
   590	
   591		if (port->rx_dma_addr) {
   592			geni_se_tx_dma_unprep(&port->se, port->tx_dma_addr,
   593					      port->tx_remaining);
 > 594			port->tx_dma_addr = (dma_addr_t)NULL;
   595			port->tx_remaining = 0;
   596		}
   597	
   598		m_irq_en = readl(uport->membase + SE_GENI_M_IRQ_EN);
   599		writel(m_irq_en, uport->membase + SE_GENI_M_IRQ_EN);
   600		geni_se_cancel_m_cmd(&port->se);
   601	
   602		done = qcom_geni_serial_poll_bit(uport, SE_GENI_S_IRQ_STATUS,
   603						 S_CMD_CANCEL_EN, true);
   604		if (!done) {
   605			geni_se_abort_m_cmd(&port->se);
   606			qcom_geni_serial_poll_bit(uport, SE_GENI_M_IRQ_STATUS,
   607						  M_CMD_ABORT_EN, true);
   608			writel(M_CMD_ABORT_EN, uport->membase + SE_GENI_M_IRQ_CLEAR);
   609		}
   610	
   611		writel(M_CMD_CANCEL_EN, uport->membase + SE_GENI_M_IRQ_CLEAR);
   612	}
   613	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (317337 bytes)