linux-kernel - Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 18:36:02 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED
 nodes

Hi,

On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote:
> LP5523 LED controller does not take enable-gpios property:
> 
>   omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

The drivers uses it via devm_gpiod_get_optional() and the binding has this:

grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
  enable-gpio:
    maxItems: 1
    description: |
      GPIO attached to the chip's enable pin

-- Sebastian


>  arch/arm/boot/dts/omap3-n900.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index ba35cff5b01e..5e78dc990725 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -636,7 +636,6 @@ lp5523: lp5523@32 {
>  		compatible = "national,lp5523";
>  		reg = <0x32>;
>  		clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */
> -		enable-gpios = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */
>  
>  		led@0 {
>  			reg = <0>;
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)