linux-kernel - Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Nov 2022 15:21:10 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: omap: n900: drop enable-gpios from LED
 nodes

On 25/11/2022 18:36, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Nov 25, 2022 at 03:41:50PM +0100, Krzysztof Kozlowski wrote:
>> LP5523 LED controller does not take enable-gpios property:
>>
>>   omap3-n900.dtb: lp5523@32: 'enable-gpios' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
> 
> The drivers uses it via devm_gpiod_get_optional() and the binding has this:
> 
> grep -A3 enable-gpio Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
>   enable-gpio:
>     maxItems: 1
>     description: |
>       GPIO attached to the chip's enable pin
> 
> -- Sebastian

Oh, thanks, I am pretty sure i was checking it but maybe I looked at
wrong driver :(.

I'll fix it in different way.


Best regards,
Krzysztof