linux-kernel - Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54f500cb-d7d0-8af1-eb58-99fbe71791a5@linaro.org>
Date:   Sat, 26 Nov 2022 15:24:52 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     neil.armstrong@...aro.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

On 26/11/2022 15:16, Krzysztof Kozlowski wrote:
> On 25/11/2022 18:16, Neil Armstrong wrote:
>> On 25/11/2022 15:41, Krzysztof Kozlowski wrote:
>>> The node names should be generic and DT schema expects certain pattern:
>>>
>>>    amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>   arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>>
>> <snip>
>>
>>
>> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> 
> Aren't you maintainer of the platform? This means I should take care of
> this patch?

Ah, this will be picked up by Kevin or Jerome? So this tag means only
Reviewer's statement of oversight, right?

Best regards,
Krzysztof