[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y4EDinQApvqheyZC@smile.fi.intel.com>
Date: Fri, 25 Nov 2022 20:03:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tharunkumar.Pasumarthi@...rochip.com
Cc: Kumaravel.Thiagarajan@...rochip.com, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org, gregkh@...uxfoundation.org,
jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com,
macro@...am.me.uk, jay.dolan@...esio.com, cang1@...e.co.uk,
u.kleine-koenig@...gutronix.de, wander@...hat.com,
etremblay@...tech-controls.com, jk@...abs.org,
biju.das.jz@...renesas.com, geert+renesas@...der.be,
phil.edworthy@...esas.com, lukas@...ner.de,
UNGLinuxDriver@...rochip.com, colin.i.king@...il.com
Subject: Re: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver
for quad-uart support.
On Fri, Nov 25, 2022 at 03:45:01PM +0000, Tharunkumar.Pasumarthi@...rochip.com wrote:
> > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Sent: Thursday, November 17, 2022 1:55 PM
...
> > > + case PCI_SUBDEVICE_ID_EFAR_PCI11414:
> > > + irq_idx = idx;
> > > + break;
> >
> > Try to make this entire switch-case more compact. It's possible.
>
> I am planning to use look-up table for this in-order to avoid computation
> within switch case. Does this approach sound good?
Maybe, it's you who decides, just show us the result and we will see.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists