linux-kernel - RE: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for quad-uart support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB595813B2AB661CD50517DEB89B0E9@PH7PR11MB5958.namprd11.prod.outlook.com>
Date:   Fri, 25 Nov 2022 15:45:01 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <andriy.shevchenko@...ux.intel.com>,
        <Kumaravel.Thiagarajan@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <ilpo.jarvinen@...ux.intel.com>, <macro@...am.me.uk>,
        <jay.dolan@...esio.com>, <cang1@...e.co.uk>,
        <u.kleine-koenig@...gutronix.de>, <wander@...hat.com>,
        <etremblay@...tech-controls.com>, <jk@...abs.org>,
        <biju.das.jz@...renesas.com>, <geert+renesas@...der.be>,
        <phil.edworthy@...esas.com>, <lukas@...ner.de>,
        <UNGLinuxDriver@...rochip.com>, <colin.i.king@...il.com>
Subject: RE: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for
 quad-uart support.

> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Thursday, November 17, 2022 1:55 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>
> Subject: Re: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for
> quad-uart support.
> 
> > +     case PCI_SUBDEVICE_ID_EFAR_PCI11414:
> > +             irq_idx = idx;
> > +             break;
> 
> Try to make this entire switch-case more compact. It's possible.

Hi Andy,
I am planning to use look-up table for this in-order to avoid computation within switch case. Does this approach sound good?

Thanks,
Tharun Kumar P