[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANiq72ntFXb+ZhBqgBAMu2n8wcgJLZRZC1rmBVvL5m+K1Nhw2w@mail.gmail.com>
Date: Fri, 25 Nov 2022 19:50:47 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Liam Howlett <liam.howlett@...cle.com>
Cc: "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
"linux-sparse@...r.kernel.org" <linux-sparse@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Miguel Ojeda <ojeda@...nel.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] tools: Rename __fallthrough to fallthrough
On Fri, Nov 25, 2022 at 4:50 PM Liam Howlett <liam.howlett@...cle.com> wrote:
>
> Rename the fallthrough attribute to better align with the kernel
> version. Copy the definition from include/linux/compiler_attributes.h
> including the #else clause. Adding the #else clause allows the tools
> compiler.h header to drop the check for a definition entirely and keeps
> both definitions together.
Thanks for doing this! Consistency with `tools/` is nice to have indeed.
I see that `compiler-gcc.h` is included for Clang too in `tools/`, so
it looks fine to me:
Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
In the future, it could be nice to enable the warning for Clang too,
though I see it requires a few cleanups.
Another idea is to use something similar to `compiler_attributes.h` in
`tools/` (perhaps just copying it and removing what is not needed?).
Cheers,
Miguel
Powered by blists - more mailing lists