[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230406195830.ieiozetmk7qjllol@revolver>
Date: Thu, 6 Apr 2023 15:58:30 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
"linux-sparse@...r.kernel.org" <linux-sparse@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Miguel Ojeda <ojeda@...nel.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] tools: Rename __fallthrough to fallthrough
* Miguel Ojeda <miguel.ojeda.sandonis@...il.com> [221125 13:51]:
> On Fri, Nov 25, 2022 at 4:50 PM Liam Howlett <liam.howlett@...cle.com> wrote:
> >
> > Rename the fallthrough attribute to better align with the kernel
> > version. Copy the definition from include/linux/compiler_attributes.h
> > including the #else clause. Adding the #else clause allows the tools
> > compiler.h header to drop the check for a definition entirely and keeps
> > both definitions together.
>
> Thanks for doing this! Consistency with `tools/` is nice to have indeed.
>
> I see that `compiler-gcc.h` is included for Clang too in `tools/`, so
> it looks fine to me:
>
> Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
>
Any chance of this being accepted? I'm looking to use this in the radix
test suite and would rather not duplicate code.
> In the future, it could be nice to enable the warning for Clang too,
> though I see it requires a few cleanups.
>
> Another idea is to use something similar to `compiler_attributes.h` in
> `tools/` (perhaps just copying it and removing what is not needed?).
>
> Cheers,
> Miguel
Powered by blists - more mailing lists