lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <202211261240.Uk43arFY-lkp@intel.com>
Date: Sat, 26 Nov 2022 13:03:21 +0800
From: kernel test robot <lkp@...el.com>
To: Kemeng Shi <shikemeng@...wei.com>, tj@...nel.org,
josef@...icpanda.com, axboe@...nel.dk
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
cgroups@...r.kernel.org, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, shikemeng@...wei.com
Subject: Re: [PATCH 05/11] blk-throttle: simpfy low limit reached check in
throtl_tg_can_upgrade
Hi Kemeng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.1-rc6 next-20221125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kemeng-Shi/A-few-bugfix-and-cleanup-patches-for-blk-throttle/20221123-140704
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20221123060401.20392-6-shikemeng%40huawei.com
patch subject: [PATCH 05/11] blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade
config: x86_64-randconfig-a005
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/79d5eb2da90b359d735d434c745a5d6f9c1a690c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kemeng-Shi/A-few-bugfix-and-cleanup-patches-for-blk-throttle/20221123-140704
git checkout 79d5eb2da90b359d735d434c745a5d6f9c1a690c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> block/blk-throttle.c:1813:1: error: expected identifier
}
^
1 error generated.
vim +1813 block/blk-throttle.c
1802
1803 static bool throtl_tg_reach_low_limit(struct throtl_grp *tg, int rw)
1804 {
1805 struct throtl_service_queue *sq = &tg->service_queue;
1806 bool limit = tg->bps[rw][LIMIT_LOW] || tg->iops[rw][LIMIT_LOW];
1807
1808 /*
1809 * if cgroup reaches low limit (if low limit is 0, the cgroup always
1810 * reaches), it's ok to upgrade to next limit
1811 */
1812 return !limit || sq->nr_queued[rw].
> 1813 }
1814
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (141251 bytes)
Powered by blists - more mailing lists