linux-kernel - Re: [PATCH 08/11] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Nov 2022 16:15:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kemeng Shi <shikemeng@...wei.com>, tj@...nel.org,
        josef@...icpanda.com, axboe@...nel.dk
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, shikemeng@...wei.com
Subject: Re: [PATCH 08/11] blk-throttle: remove repeat check of elapsed time
 from last upgrade in throtl_hierarchy_can_downgrade

Hi Kemeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.1-rc6 next-20221125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kemeng-Shi/A-few-bugfix-and-cleanup-patches-for-blk-throttle/20221123-140704
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20221123060401.20392-9-shikemeng%40huawei.com
patch subject: [PATCH 08/11] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade
config: x86_64-randconfig-a005
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f01c7d5bc75515a315dff091b1b1aa1ea1ef12fc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kemeng-Shi/A-few-bugfix-and-cleanup-patches-for-blk-throttle/20221123-140704
        git checkout f01c7d5bc75515a315dff091b1b1aa1ea1ef12fc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   block/blk-throttle.c:1812:1: error: expected identifier
   }
   ^
>> block/blk-throttle.c:1945:50: error: use of undeclared identifier 'td'
           if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice))
                                                           ^
>> block/blk-throttle.c:1945:18: error: use of undeclared identifier 'now'
           if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice))
                           ^
>> block/blk-throttle.c:1945:18: error: use of undeclared identifier 'now'
>> block/blk-throttle.c:1945:50: error: use of undeclared identifier 'td'
           if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice))
                                                           ^
   5 errors generated.


vim +/td +1945 block/blk-throttle.c

  1942	
  1943	static bool throtl_hierarchy_can_downgrade(struct throtl_grp *tg)
  1944	{
> 1945		if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice))
  1946			return false;
  1947	
  1948		while (true) {
  1949			if (!throtl_tg_can_downgrade(tg))
  1950				return false;
  1951			tg = sq_to_tg(tg->service_queue.parent_sq);
  1952			if (!tg || !tg_to_blkg(tg)->parent)
  1953				break;
  1954		}
  1955		return true;
  1956	}
  1957	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (141251 bytes)