lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y4IARpGaqfvHtu75@smile.fi.intel.com> Date: Sat, 26 Nov 2022 14:02:14 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Wang Yufen <wangyufen@...wei.com> Cc: bvanassche@....org, jgg@...pe.ca, leon@...nel.org, dennis.dalessandro@...nelisnetworks.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, bart.vanassche@....com, easwar.hariharan@...el.com Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse_options() On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote: > In the previous while loop, "ret" may be assigned zero, , so the error > return code may be incorrectly set to 0 instead of -EINVAL. > Add out_with_einval goto label and covert all "goto out;" to "goto > out_with_einval:" where it's appropriate, alse investigate each case > separately as Andy suggessted. It's better now, though you missed something... ... > case SRP_OPT_TARGET_CAN_QUEUE: > - if (match_int(args, &token) || token < 1) { > + ret = match_int(args, &token); Check for ret? > + if (token < 1) { > pr_warn("bad max target_can_queue parameter '%s'\n", > p); > - goto out; > + goto out_with_einval; > } > target->target_can_queue = token; > break; ... > target->scsi_host->can_queue); The below can't be like this, right? > +out_with_einval: > + ret = -EINVAL; > out: > kfree(options); > return ret; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists