lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y4IAky87PxC/J7lr@smile.fi.intel.com> Date: Sat, 26 Nov 2022 14:03:31 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Wang Yufen <wangyufen@...wei.com> Cc: bvanassche@....org, jgg@...pe.ca, leon@...nel.org, dennis.dalessandro@...nelisnetworks.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, bart.vanassche@....com, easwar.hariharan@...el.com Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse_options() On Sat, Nov 26, 2022 at 02:02:14PM +0200, Andy Shevchenko wrote: > On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote: ... > > target->scsi_host->can_queue); > > The below can't be like this, right? > > > +out_with_einval: > > + ret = -EINVAL; > > out: > > kfree(options); > > return ret; One option is: out: kfree(options); return ret; out_with_einval: ret = -EINVAL; goto out; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists