linux-kernel - Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c9c2a4a-844f-70d6-8f93-1f13a0612bf3@huawei.com>
Date:   Sat, 26 Nov 2022 21:19:50 +0800
From:   wangyufen <wangyufen@...wei.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     <bvanassche@....org>, <jgg@...pe.ca>, <leon@...nel.org>,
        <dennis.dalessandro@...nelisnetworks.com>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <bart.vanassche@....com>, <easwar.hariharan@...el.com>
Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in
 srp_parse_options()



在 2022/11/26 20:03, Andy Shevchenko 写道:
> On Sat, Nov 26, 2022 at 02:02:14PM +0200, Andy Shevchenko wrote:
>> On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote:
> 
> ...
> 
>>>   			target->scsi_host->can_queue);
>>
>> The below can't be like this, right?
>>
>>> +out_with_einval:
>>> +	ret = -EINVAL;
>>>   out:
>>>   	kfree(options);
>>>   	return ret;
> 
> One option is:
> 
> out:
> 	kfree(options);
> 	return ret;
> 
> out_with_einval:
> 	ret = -EINVAL;
> 	goto out;

I got it.
Thanks!

> 
>