lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Y4JL89BCcs1pjWZZ@lunn.ch> Date: Sat, 26 Nov 2022 18:25:07 +0100 From: Andrew Lunn <andrew@...n.ch> To: Zheng Yongjun <zhengyongjun3@...wei.com> Cc: eajames@...ux.ibm.com, mchehab@...nel.org, linux-media@...r.kernel.org, openbmc@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, joel@....id.au, andrew@...id.au Subject: Re: [PATCH v2] media: aspeed: Fix return value check in aspeed_video_debugfs_create() On Sat, Nov 26, 2022 at 02:28:13AM +0000, Zheng Yongjun wrote: > In case of error, the function debugfs_create_file() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Fixes: 52fed10ad756 ("media: aspeed: add debugfs") > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com> Please see: https://patchwork.kernel.org/project/linux-wireless/patch/20200429101526.GA2094124@kroah.com/ and there are other examples. Just delete all the checks. Andrew
Powered by blists - more mailing lists