lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221126022813.57372-1-zhengyongjun3@huawei.com> Date: Sat, 26 Nov 2022 02:28:13 +0000 From: Zheng Yongjun <zhengyongjun3@...wei.com> To: <eajames@...ux.ibm.com>, <mchehab@...nel.org>, <linux-media@...r.kernel.org>, <openbmc@...ts.ozlabs.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-aspeed@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org> CC: <joel@....id.au>, <andrew@...id.au> Subject: [PATCH v2] media: aspeed: Fix return value check in aspeed_video_debugfs_create() In case of error, the function debugfs_create_file() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 52fed10ad756 ("media: aspeed: add debugfs") Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com> --- v2: - change return error code from ERR_PTR to PTR_ERR. drivers/media/platform/aspeed/aspeed-video.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/platform/aspeed/aspeed-video.c index 20f795ccc11b..0113e6bc836f 100644 --- a/drivers/media/platform/aspeed/aspeed-video.c +++ b/drivers/media/platform/aspeed/aspeed-video.c @@ -1780,10 +1780,12 @@ static int aspeed_video_debugfs_create(struct aspeed_video *video) debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL, video, &aspeed_video_debugfs_ops); - if (!debugfs_entry) + if (IS_ERR(debugfs_entry)) { aspeed_video_debugfs_remove(video); + return PTR_ERR(debugfs_entry); + } - return !debugfs_entry ? -EIO : 0; + return 0; } #else static void aspeed_video_debugfs_remove(struct aspeed_video *video) { } -- 2.17.1
Powered by blists - more mailing lists