lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <105b9113-8322-aa68-7d21-45f5ba288d34@acm.org> Date: Fri, 25 Nov 2022 17:10:25 -0800 From: Bart Van Assche <bvanassche@....org> To: Asutosh Das <quic_asutoshd@...cinc.com>, quic_cang@...cinc.com, martin.petersen@...cle.com, linux-scsi@...r.kernel.org Cc: quic_nguyenb@...cinc.com, quic_xiaosenh@...cinc.com, stanley.chu@...iatek.com, eddie.huang@...iatek.com, daejun7.park@...sung.com, avri.altman@....com, mani@...nel.org, beanhuo@...ron.com, linux-arm-msm@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v5 06/16] ufs: core: mcq: Configure resource regions On 11/22/22 20:10, Asutosh Das wrote: > +/* Resources */ > +static const struct ufshcd_res_info ufs_res_info[RES_MAX] = { > + {.name = "ufs_mem",}, > + {.name = "mcq",}, > + /* Submission Queue DAO */ > + {.name = "mcq_sqd",}, > + /* Submission Queue Interrupt Status */ > + {.name = "mcq_sqis",}, > + /* Completion Queue DAO */ > + {.name = "mcq_cqd",}, > + /* Completion Queue Interrupt Status */ > + {.name = "mcq_cqis",}, > + /* MCQ vendor specific */ > + {.name = "mcq_vs",}, > +}; Which names to associate with nodes in the device tree for UFS MCQ resources has not been standardized. Additionally, the UFS driver is also used on platforms that do not support the device tree (e.g. Intel x86 platforms). So I don't think that the platform_get_resource_byname() calls should occur in the UFS driver core. How about moving the code that queries device tree nodes into the Qualcomm driver until a second user of this code is added? If a second user of this code appears this code could e.g. become a kernel module shared by both UFS host controller drivers. Thanks, Bart.
Powered by blists - more mailing lists