linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpoe09FZcfVXuknmFWO5qg-iYDOBVN3=qr=DeJjvHw56Mw@mail.gmail.com>
Date:   Sun, 27 Nov 2022 23:25:59 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Luca Weiss <luca@...tu.xyz>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device

On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@...tu.xyz> wrote:
>
> Document the OnePlus One ("bacon") which is a smartphone based on the
> Snapdragon 801 SoC.
>
> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id.

The patch itself is good. However it raised a broader question for me.
Up to now all msm8974pro devices use qcom,msm8974 as a top-level
compatibility string. Should it be changed to use pro-specific one
(e.g. qcom,msm8974pro)?

For the patch itself:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

>
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 463509f0f23a..3d2cc8ae34d8 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -167,6 +167,7 @@ properties:
>            - enum:
>                - fairphone,fp2
>                - lge,hammerhead
> +              - oneplus,bacon
>                - samsung,klte
>                - sony,xperia-amami
>                - sony,xperia-castor
> @@ -896,6 +897,7 @@ allOf:
>                - qcom,apq8026
>                - qcom,apq8094
>                - qcom,apq8096
> +              - qcom,msm8974
>                - qcom,msm8992
>                - qcom,msm8994
>                - qcom,msm8996
> --
> 2.38.1
>


-- 
With best wishes
Dmitry