linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0a15b01-81b6-5c73-6c35-ce3a8c71b4ad@linaro.org>
Date:   Sun, 27 Nov 2022 22:30:14 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Luca Weiss <luca@...tu.xyz>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device

On 27/11/2022 22:25, Dmitry Baryshkov wrote:
> On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@...tu.xyz> wrote:
>>
>> Document the OnePlus One ("bacon") which is a smartphone based on the
>> Snapdragon 801 SoC.
>>
>> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id.
> 
> The patch itself is good. However it raised a broader question for me.
> Up to now all msm8974pro devices use qcom,msm8974 as a top-level
> compatibility string. Should it be changed to use pro-specific one
> (e.g. qcom,msm8974pro)?

Yes, makes sense.

Best regards,
Krzysztof