linux-kernel - Re: [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a9e7d65-4ad7-b753-ec9b-8e58a549b5db@sberdevices.ru>
Date:   Mon, 28 Nov 2022 17:43:19 +0000
From:   Martin Kurbanov <MMKurbanov@...rdevices.ru>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        "Andy Shevchenko" <andy.shevchenko@...il.com>
CC:     "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        kernel <kernel@...rdevices.ru>
Subject: Re: [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx

Hi. Thank you for quick reply. 

On 25.11.2022 11:29, Krzysztof Kozlowski wrote:
>> +
>> +  imax:
>> +    maxItems: 1
>> +    description:
>> +      Maximum supply current, see dt-bindings/leds/leds-aw200xx.h
> 
> No. Use existing properties from common.yaml. This looks like
> led-max-microamp and it is per LED, not per entire device.

The AW200XX LED chip does not support imax setup per led.
Imax is the global parameter over the all leds. I suppose, it's better
to add vendor prefix or take minimum from all subnodes?
How do you think?


>> +/* Global max current (IMAX) */
>> +#define AW200XX_IMAX_3_3MA  8
>> +#define AW200XX_IMAX_6_7MA  9
> 
> No. Bindings are not for storing register constants. Feel free to store
> here IDs (ID start from 0 or 1 and is incremented by 1)... but how the
> IMAX even matches any need for "ID"?

IMAX can be chosen from the predefined values in the
datasheet (10mA, 20mA, etc). Do you mean the IMAX should be round down
to nearest supported value in the driver?

-- 
Best Regards,
Kurbanov Martin