[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb9e8610-588e-6e56-ee33-8716008e7905@sberdevices.ru>
Date: Mon, 28 Nov 2022 17:45:22 +0000
From: Martin Kurbanov <MMKurbanov@...rdevices.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jonathan Corbet <corbet@....net>,
"Andy Shevchenko" <andy.shevchenko@...il.com>
CC: "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
kernel <kernel@...rdevices.ru>
Subject: Re: [PATCH v1 2/2] leds: add aw20xx driver
On 25.11.2022 11:19, Krzysztof Kozlowski wrote:
>> + $ ls -l /sys/bus/i2c/devices/xxxx/pattern0/
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 clear_leds
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 fall_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_begin
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_end_on
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 max_breathing_level
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 min_breathing_level
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 mode
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 off_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 on_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 ramp
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 repeat
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 rise_time
>> + -r--r--r-- 1 root root 4096 Jan 1 00:00 running
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 select_leds
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 start
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 toggle
>
> sysfs documentation goes to Documentation/ABI/
Should I add it to Documentation/ABI/testing/sysfs-class-led-driver-aw200xx?
Is my understanding correct?
Is KernelVersion parameter required?
>> + chip = devm_kzalloc(&client->dev,
>> + struct_size(chip, leds, count),
>
> sizeof(*chip)
Unfortunately, it will not work. Because I want to calculate the whole
size of chip structure, it has flexible array member inside.
--
Best Regards,
Kurbanov Martin
Powered by blists - more mailing lists