linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4T+Mv+uIx7jQwky@gerhold.net>
Date:   Mon, 28 Nov 2022 19:30:10 +0100
From:   Stephan Gerhold <stephan@...hold.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     "Lin, Meng-Bo" <linmengbo0689@...tonmail.com>,
        linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nikita Travkin <nikita@...n.ru>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        André Apitzsch <git@...tzsch.eu>,
        Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] arm64: dts: qcom: msm8916-wingtech-wt88047: Add flash LED

Hi Krzysztof,

On Mon, Nov 28, 2022 at 09:56:47AM +0100, Krzysztof Kozlowski wrote:
> On 28/11/2022 06:16, Lin, Meng-Bo wrote:
> > WT88047 uses OCP 8110 Flash LED driver. Add it to the device tree.
> > 
> > Signed-off-by: Lin, Meng-Bo <linmengbo0689@...tonmail.com>
> > ---
> >  .../dts/qcom/msm8916-wingtech-wt88047.dts     | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
> > index 166bed05996f..a87be1d95b14 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
> > +++ b/arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dts
> > @@ -23,6 +23,20 @@ chosen {
> >  		stdout-path = "serial0";
> >  	};
> >  
> > +	flash-led-controller {
> > +		compatible = "ocs,ocp8110";
> 
> The compatible is not documented. Checkpatch warns about it. You need to
> document devices before using them.
> 

Unfortunately Pavel never applied the dt-bindings patch for this - only
the driver patch was applied. André already sent a kind reminder [1] and
two resends [2, 3] without success. Since it's a documentation-only
patch, maybe you could take it through the dt-bindings tree?

Even the original version [1] still applies cleanly to linux-next. :)

Thanks,
Stephan

[1]: https://lore.kernel.org/linux-leds/20220212180942.8241-2-git@apitzsch.eu/
[2]: https://lore.kernel.org/linux-leds/20220404161428.17175-1-git@apitzsch.eu/
[3]: https://lore.kernel.org/linux-leds/20220505185344.10067-1-git@apitzsch.eu/