linux-kernel - Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv24PiCW_9svBCLF8W+rkb=w90fBCEYOuFAkozXUQu_kLQ@mail.gmail.com>
Date:   Mon, 28 Nov 2022 10:27:30 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include

Though I think having the target tree specified conventionally in the
subject line [PATCH net] would be more complying with the process.

On Mon, Nov 28, 2022 at 9:57 AM Pavan Chebbi <pavan.chebbi@...adcom.com> wrote:
>
> On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
> <christophe.jaillet@...adoo.fr> wrote:
> >
> > The mlx5 net files don't use io_mapping functionalities. So there is no
> > point in including <linux/io-mapping.h>.
> > Remove it.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/cmd.c  | 1 -
> >  drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> >  drivers/net/ethernet/mellanox/mlx5/core/uar.c  | 1 -
> >  3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > index 74bd05e5dda2..597907fd63f5 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > @@ -37,7 +37,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/delay.h>
> >  #include <linux/random.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/mlx5/driver.h>
> >  #include <linux/mlx5/eq.h>
> >  #include <linux/debugfs.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > index 70e8dc305bec..25e87e5d9270 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > @@ -37,7 +37,6 @@
> >  #include <linux/pci.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/slab.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/delay.h>
> >  #include <linux/mlx5/driver.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > index 8455e79bc44a..1513112ecec8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > @@ -31,7 +31,6 @@
> >   */
> >
> >  #include <linux/kernel.h>
> > -#include <linux/io-mapping.h>
> >  #include <linux/mlx5/driver.h>
> >  #include "mlx5_core.h"
> >
> > --
> > 2.34.1
> >
>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)