linux-kernel - Re: [PATCH] thermal/core/power allocator: Remove a useless include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <283adb73-99c2-4215-0711-26ff0f73da26@arm.com>
Date:   Mon, 28 Nov 2022 07:19:53 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH] thermal/core/power allocator: Remove a useless include



On 11/26/22 10:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
> 
> Remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/thermal/gov_power_allocator.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index 2d1aeaba38a8..d5d4eae16771 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -8,7 +8,6 @@
>   
>   #define pr_fmt(fmt) "Power allocator: " fmt
>   
> -#include <linux/rculist.h>
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   

Good catch.

Reviewed-by: Lukasz Luba <lukasz.luba@....com>