linux-kernel - Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <669d0399-dbc7-965a-9e50-017f017ca823@linaro.org>
Date:   Mon, 28 Nov 2022 08:17:41 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

Hi Krzysztof,

Le 27/11/2022 à 20:07, Krzysztof Kozlowski a écrit :
> On 27/11/2022 14:33, Neil Armstrong wrote:
>>
>> Le 27/11/2022 à 13:25, Krzysztof Kozlowski a écrit :
>>> On 26/11/2022 17:03, Neil Armstrong wrote:
>>>>>>> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
>>>>>> Aren't you maintainer of the platform? This means I should take care of
>>>>>> this patch?
>>>>> Ah, this will be picked up by Kevin or Jerome? So this tag means only
>>>>> Reviewer's statement of oversight, right?
>>>> Of course I'll pick it.
>>>>
>>> So that's confusing to see Review which does not mean review, but
>>> maintainer pick...
>>
>> Reviewed-by means reviewed, there's no confusion here, the significance
>> is clearly documented on https://docs.kernel.org/process/submitting-patches.html
>>
>>>
>>> Reviewed-by means, I should take your tag and add to v2 or the
>>> maintainer will add it when picking up.
>>
>> Reviewed-by means reviewed, fully reviewed patches are ready to
>> be picked unless a change is asked by a reviewer.
>>
>> Decision to pick or not a patch does not depend on any tags, but
>> is the sole decision of the maintainer adding it's Signed-off-by.
> 
> Then why giving review tag and not notifying about the pick, while the
> pick actually happens? This is confusing. When the maintainer, which is
> supposed to pick patch, gives reviewed it means always the same as
> acked, so the patch is expected to go other way. Not through that
> maintainer's tree.
> 
> If you just apply it, say you apply it.

This last reply goes beyond acceptability on my side, this thread
went too far and I'll stop replying further after this.

If your goal was to kindly ask me to use Acked-by to notify you I'll
pick the patch in the future, while this "rule" is only implicit,
the actual form is far from it.

Concerning this patch, since I already sent the ARM64 DT PR for v6.2,
and I usually don't take new changes except urgent ones after rc6, I'll
pick this patch and "20221125144120.476933-1-krzysztof.kozlowski@...aro.org"
after the next merge window and you'll be notified as I always do.

> 
> Best regards,
> Krzysztof
> 

Neil