linux-kernel - Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2022 20:07:07 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema

On 27/11/2022 14:33, Neil Armstrong wrote:
> 
> Le 27/11/2022 à 13:25, Krzysztof Kozlowski a écrit :
>> On 26/11/2022 17:03, Neil Armstrong wrote:
>>>>>> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
>>>>> Aren't you maintainer of the platform? This means I should take care of
>>>>> this patch?
>>>> Ah, this will be picked up by Kevin or Jerome? So this tag means only
>>>> Reviewer's statement of oversight, right?
>>> Of course I'll pick it.
>>>
>> So that's confusing to see Review which does not mean review, but
>> maintainer pick...
> 
> Reviewed-by means reviewed, there's no confusion here, the significance
> is clearly documented on https://docs.kernel.org/process/submitting-patches.html
> 
>>
>> Reviewed-by means, I should take your tag and add to v2 or the
>> maintainer will add it when picking up.
> 
> Reviewed-by means reviewed, fully reviewed patches are ready to
> be picked unless a change is asked by a reviewer.
> 
> Decision to pick or not a patch does not depend on any tags, but
> is the sole decision of the maintainer adding it's Signed-off-by.

Then why giving review tag and not notifying about the pick, while the
pick actually happens? This is confusing. When the maintainer, which is
supposed to pick patch, gives reviewed it means always the same as
acked, so the patch is expected to go other way. Not through that
maintainer's tree.

If you just apply it, say you apply it.

Best regards,
Krzysztof