linux-kernel - Re: [PATCH 001/606] tpm: st33zp24: Convert to Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4QLjYWvqYQUtohO@kernel.org>
Date:   Mon, 28 Nov 2022 03:14:53 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Peter Huewe <peterhuewe@....de>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Maximilian Luz <luzmaximilian@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 001/606] tpm: st33zp24: Convert to Convert to i2c's
 .probe_new()

On Fri, Nov 18, 2022 at 11:35:35PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/char/tpm/st33zp24/i2c.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c
> index 614c7d8ed84f..0cd614933b4a 100644
> --- a/drivers/char/tpm/st33zp24/i2c.c
> +++ b/drivers/char/tpm/st33zp24/i2c.c
> @@ -101,8 +101,7 @@ static const struct st33zp24_phy_ops i2c_phy_ops = {
>   * @return: 0 in case of success.
>   *	 -1 in other case.
>   */
> -static int st33zp24_i2c_probe(struct i2c_client *client,
> -			      const struct i2c_device_id *id)
> +static int st33zp24_i2c_probe(struct i2c_client *client)
>  {
>  	struct st33zp24_i2c_phy *phy;
>  
> @@ -167,7 +166,7 @@ static struct i2c_driver st33zp24_i2c_driver = {
>  		.of_match_table = of_match_ptr(of_st33zp24_i2c_match),
>  		.acpi_match_table = ACPI_PTR(st33zp24_i2c_acpi_match),
>  	},
> -	.probe = st33zp24_i2c_probe,
> +	.probe_new = st33zp24_i2c_probe,
>  	.remove = st33zp24_i2c_remove,
>  	.id_table = st33zp24_i2c_id
>  };
> -- 
> 2.38.1
> 

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko