linux-kernel - Re: [PATCH 002/606] tpm: tpm_i2c_atmel: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4QLoyCfVefb6bo5@kernel.org>
Date:   Mon, 28 Nov 2022 03:15:15 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Grant Likely <grant.likely@...aro.org>,
        Wolfram Sang <wsa@...nel.org>, Peter Huewe <peterhuewe@....de>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 002/606] tpm: tpm_i2c_atmel: Convert to i2c's .probe_new()

On Fri, Nov 18, 2022 at 11:35:36PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/char/tpm/tpm_i2c_atmel.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
> index 4be3677c1463..8f77154e0550 100644
> --- a/drivers/char/tpm/tpm_i2c_atmel.c
> +++ b/drivers/char/tpm/tpm_i2c_atmel.c
> @@ -146,8 +146,7 @@ static const struct tpm_class_ops i2c_atmel = {
>  	.req_canceled = i2c_atmel_req_canceled,
>  };
>  
> -static int i2c_atmel_probe(struct i2c_client *client,
> -			   const struct i2c_device_id *id)
> +static int i2c_atmel_probe(struct i2c_client *client)
>  {
>  	struct tpm_chip *chip;
>  	struct device *dev = &client->dev;
> @@ -204,7 +203,7 @@ static SIMPLE_DEV_PM_OPS(i2c_atmel_pm_ops, tpm_pm_suspend, tpm_pm_resume);
>  
>  static struct i2c_driver i2c_atmel_driver = {
>  	.id_table = i2c_atmel_id,
> -	.probe = i2c_atmel_probe,
> +	.probe_new = i2c_atmel_probe,
>  	.remove = i2c_atmel_remove,
>  	.driver = {
>  		.name = I2C_DRIVER_NAME,
> -- 
> 2.38.1
> 

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko