linux-kernel - Re: [PATCH] media/i2c: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeea8927-1b0e-6a0b-12e5-b94097caed11@xs4all.nl>
Date:   Mon, 28 Nov 2022 09:56:08 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     wangjianli <wangjianli@...rlc.com>, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media/i2c: fix repeated words in comments

On 08/09/2022 14:30, wangjianli wrote:
> Delete the redundant word 'in'.
> 
> Signed-off-by: wangjianli <wangjianli@...rlc.com>
> ---
>  drivers/media/i2c/adv7175.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/adv7175.c b/drivers/media/i2c/adv7175.c
> index b58689728243..bc8f8bbedb45 100644
> --- a/drivers/media/i2c/adv7175.c
> +++ b/drivers/media/i2c/adv7175.c
> @@ -209,7 +209,7 @@ static int adv7175_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
>  		/* This is an attempt to convert
>  		 * SECAM->PAL (typically it does not work
>  		 * due to genlock: when decoder is in SECAM
> -		 * and encoder in in PAL the subcarrier can
> +		 * and encoder in PAL the subcarrier can

As Randy said, this should be: is in

>  		 * not be synchronized with horizontal
>  		 * quency) */

And while at it, let's replace 'quency' with 'frequency'.

>  		adv7175_write_block(sd, init_pal, sizeof(init_pal));

And PLEASE add the driver name to the subject line.

If it starts with 'media/i2c' then that suggests the patch changes
multiple files in that directory. With 'media: i2c: adv7175:' I
know it is just for that driver.

Regards,

	Hans